xuguopeng/rrweb
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't trust the html 'value' attribute on <option> - the DOM .selected is the one we want I think. (#651)

Browse Source 
- encountered inconsistent html with multiple <option> elements with the same value attribute
 - due to check `attributes.selected = (n as HTMLOptionElement).selected;` the extra ones were being stored as `selected: false`; furthermore, the `false` value was being ignored upon replay, and so the last of the extra ones was being chosen as the 'selected' option
This commit is contained in:
Eoghan Murray
2026-04-01 12:00:00 +08:00
committed by GitHub
parent b35fc9197f
commit 257e8c10c9
2 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/rrweb-snapshot/src/rebuild.ts
View File

@@ -149,6 +149,10 @@ function buildNode(
continue; continue;
} }
let value = n.attributes[name]; let value = n.attributes[name];
if (tagName === 'option' && name === 'selected' && value === false) {
// legacy fix (TODO: if `value === false` can be generated for other attrs, should we also omit those other attrs from build?)
continue;
}
value = value =
typeof value === 'boolean' || typeof value === 'number' ? '' : value; typeof value === 'boolean' || typeof value === 'number' ? '' : value;
// attribute names start with rr_ are internal attributes added by rrweb // attribute names start with rr_ are internal attributes added by rrweb

9
packages/rrweb-snapshot/src/snapshot.ts
View File

@@ -458,9 +458,12 @@ function serializeNode(
} }
} }
if (tagName === 'option') { if (tagName === 'option') {
const selectValue = (n as HTMLOptionElement).parentElement; if ((n as HTMLOptionElement).selected) {
if (attributes.value === (selectValue as HTMLSelectElement).value) { attributes.selected = true;
attributes.selected = (n as HTMLOptionElement).selected; } else {
// ignore the html attribute (which corresponds to DOM (n as HTMLOptionElement).defaultSelected)
// if it's already been changed
delete attributes.selected;
} }
} }
// canvas image data // canvas image data