From 292f56fe9052b8e1570ef9ef652bfa5698563228 Mon Sep 17 00:00:00 2001 From: Lucky Feng Date: Wed, 1 Apr 2026 12:00:00 +0800 Subject: [PATCH] improve config definition in the console plugin (#704) One user encountered a type problem(https://rrweb.slack.com/archives/C01BYDC5C93/p1631683830050900). It turns out that definition of LogReplayConfig isn't perfect --- packages/rrweb/src/plugins/console/record/index.ts | 2 +- packages/rrweb/src/plugins/console/replay/index.ts | 4 ++-- packages/rrweb/typings/plugins/console/record/index.d.ts | 2 +- packages/rrweb/typings/plugins/console/replay/index.d.ts | 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/rrweb/src/plugins/console/record/index.ts b/packages/rrweb/src/plugins/console/record/index.ts index b7c83555..6f2547d6 100644 --- a/packages/rrweb/src/plugins/console/record/index.ts +++ b/packages/rrweb/src/plugins/console/record/index.ts @@ -19,7 +19,7 @@ export type StringifyOptions = { }; type LogRecordOptions = { - level?: LogLevel[] | undefined; + level?: LogLevel[]; lengthThreshold?: number; stringifyOptions?: StringifyOptions; logger?: Logger; diff --git a/packages/rrweb/src/plugins/console/replay/index.ts b/packages/rrweb/src/plugins/console/replay/index.ts index 8b68e72f..372a770a 100644 --- a/packages/rrweb/src/plugins/console/replay/index.ts +++ b/packages/rrweb/src/plugins/console/replay/index.ts @@ -13,8 +13,8 @@ import { type ReplayLogger = Partial void>>; type LogReplayConfig = { - level?: LogLevel[] | undefined; - replayLogger: ReplayLogger | undefined; + level?: LogLevel[]; + replayLogger?: ReplayLogger; }; const ORIGINAL_ATTRIBUTE_NAME = '__rrweb_original__'; diff --git a/packages/rrweb/typings/plugins/console/record/index.d.ts b/packages/rrweb/typings/plugins/console/record/index.d.ts index 22d9c9ce..ffda9a87 100644 --- a/packages/rrweb/typings/plugins/console/record/index.d.ts +++ b/packages/rrweb/typings/plugins/console/record/index.d.ts @@ -5,7 +5,7 @@ export declare type StringifyOptions = { depthOfLimit: number; }; declare type LogRecordOptions = { - level?: LogLevel[] | undefined; + level?: LogLevel[]; lengthThreshold?: number; stringifyOptions?: StringifyOptions; logger?: Logger; diff --git a/packages/rrweb/typings/plugins/console/replay/index.d.ts b/packages/rrweb/typings/plugins/console/replay/index.d.ts index 4f2bb815..823560cc 100644 --- a/packages/rrweb/typings/plugins/console/replay/index.d.ts +++ b/packages/rrweb/typings/plugins/console/replay/index.d.ts @@ -2,8 +2,8 @@ import { LogLevel, LogData } from '../record'; import { ReplayPlugin } from '../../../types'; declare type ReplayLogger = Partial void>>; declare type LogReplayConfig = { - level?: LogLevel[] | undefined; - replayLogger: ReplayLogger | undefined; + level?: LogLevel[]; + replayLogger?: ReplayLogger; }; export declare const getReplayConsolePlugin: (options?: LogReplayConfig) => ReplayPlugin; export {};