Add option to block animation on <title> tag (#760)
* Add option to block animation on <title> tag which can generate massive recordings on some websites (think scrolling title tag) * Add new option to slimDOMOptions type with tsdoc as suggested by Justin
This commit is contained in:
6
.changeset/title-deanimate-option.md
Normal file
6
.changeset/title-deanimate-option.md
Normal file
@@ -0,0 +1,6 @@
|
|||||||
|
---
|
||||||
|
"rrweb-snapshot": patch
|
||||||
|
"rrweb": patch
|
||||||
|
---
|
||||||
|
|
||||||
|
Add slimDOM option to block animation on <title> tag; enabled when the 'all' value is used for slimDOM
|
||||||
@@ -169,6 +169,10 @@ export type SlimDOMOptions = Partial<{
|
|||||||
headMetaHttpEquiv: boolean;
|
headMetaHttpEquiv: boolean;
|
||||||
headMetaAuthorship: boolean;
|
headMetaAuthorship: boolean;
|
||||||
headMetaVerification: boolean;
|
headMetaVerification: boolean;
|
||||||
|
/**
|
||||||
|
* blocks title tag 'animations' which can generate a lot of mutations that aren't usually displayed in replayers
|
||||||
|
**/
|
||||||
|
headTitleMutations: boolean;
|
||||||
}>;
|
}>;
|
||||||
|
|
||||||
export type DataURLOptions = Partial<{
|
export type DataURLOptions = Partial<{
|
||||||
|
|||||||
@@ -174,6 +174,7 @@ function record<T = eventWithTime>(
|
|||||||
// as they destroy some (hidden) info:
|
// as they destroy some (hidden) info:
|
||||||
headMetaAuthorship: _slimDOMOptions === 'all',
|
headMetaAuthorship: _slimDOMOptions === 'all',
|
||||||
headMetaDescKeywords: _slimDOMOptions === 'all',
|
headMetaDescKeywords: _slimDOMOptions === 'all',
|
||||||
|
headTitleMutations: _slimDOMOptions === 'all',
|
||||||
}
|
}
|
||||||
: _slimDOMOptions
|
: _slimDOMOptions
|
||||||
? _slimDOMOptions
|
? _slimDOMOptions
|
||||||
|
|||||||
@@ -530,7 +530,7 @@ export default class MutationBuffer {
|
|||||||
};
|
};
|
||||||
|
|
||||||
private processMutation = (m: mutationRecord) => {
|
private processMutation = (m: mutationRecord) => {
|
||||||
if (isIgnored(m.target, this.mirror)) {
|
if (isIgnored(m.target, this.mirror, this.slimDOMOptions)) {
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
switch (m.type) {
|
switch (m.type) {
|
||||||
@@ -688,7 +688,7 @@ export default class MutationBuffer {
|
|||||||
: this.mirror.getId(m.target);
|
: this.mirror.getId(m.target);
|
||||||
if (
|
if (
|
||||||
isBlocked(m.target, this.blockClass, this.blockSelector, false) ||
|
isBlocked(m.target, this.blockClass, this.blockSelector, false) ||
|
||||||
isIgnored(n, this.mirror) ||
|
isIgnored(n, this.mirror, this.slimDOMOptions) ||
|
||||||
!isSerialized(n, this.mirror)
|
!isSerialized(n, this.mirror)
|
||||||
) {
|
) {
|
||||||
return;
|
return;
|
||||||
@@ -747,7 +747,7 @@ export default class MutationBuffer {
|
|||||||
if (this.addedSet.has(n) || this.movedSet.has(n)) return;
|
if (this.addedSet.has(n) || this.movedSet.has(n)) return;
|
||||||
|
|
||||||
if (this.mirror.hasNode(n)) {
|
if (this.mirror.hasNode(n)) {
|
||||||
if (isIgnored(n, this.mirror)) {
|
if (isIgnored(n, this.mirror, this.slimDOMOptions)) {
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
this.movedSet.add(n);
|
this.movedSet.add(n);
|
||||||
|
|||||||
@@ -9,7 +9,7 @@ import type {
|
|||||||
DeprecatedMirror,
|
DeprecatedMirror,
|
||||||
textMutation,
|
textMutation,
|
||||||
} from '@rrweb/types';
|
} from '@rrweb/types';
|
||||||
import type { IMirror, Mirror } from 'rrweb-snapshot';
|
import type { IMirror, Mirror, SlimDOMOptions } from 'rrweb-snapshot';
|
||||||
import { isShadowRoot, IGNORED_NODE, classMatchesRegex } from 'rrweb-snapshot';
|
import { isShadowRoot, IGNORED_NODE, classMatchesRegex } from 'rrweb-snapshot';
|
||||||
import type { RRNode, RRIFrameElement } from 'rrdom';
|
import type { RRNode, RRIFrameElement } from 'rrdom';
|
||||||
|
|
||||||
@@ -276,7 +276,17 @@ export function isSerialized(n: Node, mirror: Mirror): boolean {
|
|||||||
return mirror.getId(n) !== -1;
|
return mirror.getId(n) !== -1;
|
||||||
}
|
}
|
||||||
|
|
||||||
export function isIgnored(n: Node, mirror: Mirror): boolean {
|
export function isIgnored(
|
||||||
|
n: Node,
|
||||||
|
mirror: Mirror,
|
||||||
|
slimDOMOptions: SlimDOMOptions,
|
||||||
|
): boolean {
|
||||||
|
if ((n as Element).tagName === 'TITLE' && slimDOMOptions.headTitleMutations) {
|
||||||
|
// we do this check here but not in rrweb-snapshot
|
||||||
|
// to block mutations/animations on the title.
|
||||||
|
// the headTitleMutations option isn't intended to block recording of the initial value
|
||||||
|
return true;
|
||||||
|
}
|
||||||
// The main part of the slimDOM check happens in
|
// The main part of the slimDOM check happens in
|
||||||
// rrweb-snapshot::serializeNodeWithId
|
// rrweb-snapshot::serializeNodeWithId
|
||||||
return mirror.getId(n) === IGNORED_NODE;
|
return mirror.getId(n) === IGNORED_NODE;
|
||||||
|
|||||||
Reference in New Issue
Block a user