xuguopeng/rrweb
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Perf: don't run the regex replace unless the selectorText contains a colon (#1280)

Browse Source 
* Perf: don't run the regex replace unless the selectorText contains a colon (rules generally contain colons)

* Need to check type before querying selectorText property - also good as it means we only try to fix colons at the leaf level
---------

Authored-by: eoghan murray <eoghan@getthere.ie>
This commit is contained in:
Eoghan Murray
2023-08-14 12:43:34 +01:00
committed by GitHub
parent f1b8e855b1
commit 64420c7e46
4 changed files with 18 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
packages/rrweb-snapshot/test/css.test.ts
View File

@@ -1,8 +1,5 @@
import { parse, Rule, Media } from '../src/css';
import {
validateStringifiedCssRule,
escapeImportStatement,
} from './../src/utils';
import { fixSafariColons, escapeImportStatement } from './../src/utils';
describe('css parser', () => {
it('should save the filename and source', () => {
@@ -112,15 +109,13 @@ describe('css parser', () => {
});
it('parses : in attribute selectors correctly', () => {
const out1 = validateStringifiedCssRule('[data-foo] { color: red; }');
const out1 = fixSafariColons('[data-foo] { color: red; }');
expect(out1).toEqual('[data-foo] { color: red; }');
const out2 = validateStringifiedCssRule('[data-foo:other] { color: red; }');
const out2 = fixSafariColons('[data-foo:other] { color: red; }');
expect(out2).toEqual('[data-foo\\:other] { color: red; }');
const out3 = validateStringifiedCssRule(
'[data-aa\\:other] { color: red; }',
);
const out3 = fixSafariColons('[data-aa\\:other] { color: red; }');
expect(out3).toEqual('[data-aa\\:other] { color: red; }');
});