<link> fixes re. modulepreload and fetch logic (#1614)

* `link[rel="modulepreload"]` doesn't require `as="script"` which is tied to rel="preload" only
* extract file extension properly when examining `rel="prefetch"` to disregard URL parameters correctly

Co-authored-by: Eoghan Murray <eoghan@getthere.ie>

.changeset/short-hounds-confess.md

@@ -0,0 +1,6 @@
+---
+"rrweb-snapshot": patch
+"rrweb": patch
+---
+
+Change to ignore all link[rel="modulepreload"] instead of including only those with `as="script"`

packages/rrweb-snapshot/src/rebuild.ts

@@ -7,7 +7,12 @@ import {
   type legacyAttributes,
 } from '@rrweb/types';
 import { type tagMap, type BuildCache } from './types';
-import { isElement, Mirror, isNodeMetaEqual } from './utils';
+import {
+  isElement,
+  Mirror,
+  isNodeMetaEqual,
+  extractFileExtension,
+} from './utils';
 import postcss from 'postcss';
 
 const tagMap: tagMap = {
@@ -299,16 +304,15 @@ function buildNode(
             continue;
           } else if (
             tagName === 'link' &&
-            (n.attributes.rel === 'preload' ||
+            ((n.attributes.rel === 'preload' && n.attributes.as === 'script') ||
-              n.attributes.rel === 'modulepreload') &&
+              n.attributes.rel === 'modulepreload')
-            n.attributes.as === 'script'
           ) {
             // ignore
           } else if (
             tagName === 'link' &&
             n.attributes.rel === 'prefetch' &&
             typeof n.attributes.href === 'string' &&
-            n.attributes.href.endsWith('.js')
+            extractFileExtension(n.attributes.href) === 'js'
           ) {
             // ignore
           } else if (

packages/rrweb-snapshot/src/snapshot.ts

@@ -819,9 +819,8 @@ function slimDOMExcluded(
       (sn.tagName === 'script' ||
         // (module)preload link
         (sn.tagName === 'link' &&
-          (sn.attributes.rel === 'preload' ||
+          ((sn.attributes.rel === 'preload' && sn.attributes.as === 'script') ||
-            sn.attributes.rel === 'modulepreload') &&
+            sn.attributes.rel === 'modulepreload')) ||
-          sn.attributes.as === 'script') ||
         // prefetch link
         (sn.tagName === 'link' &&
           sn.attributes.rel === 'prefetch' &&