xuguopeng/rrweb
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix #864 use for loop instead of forEach

Browse Source
This commit is contained in:
Yanzhen Yu
2026-04-01 12:00:00 +08:00
parent c67a48df70
commit e0441292a2
1 changed files with 26 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
packages/rrweb-snapshot/src/snapshot.ts
View File

@@ -298,11 +298,17 @@ export function needMaskingText(
return true; return true;
} }
} else { } else {
(node as HTMLElement).classList.forEach((className) => { // tslint:disable-next-line: prefer-for-of
for (
let eIndex = 0;
eIndex < (node as HTMLElement).classList.length;
eIndex++
) {
const className = (node as HTMLElement).classList[eIndex];
if (maskTextClass.test(className)) { if (maskTextClass.test(className)) {
return true; return true;
} }
}); }
} }
if (maskTextSelector) { if (maskTextSelector) {
if ((node as HTMLElement).matches(maskTextSelector)) { if ((node as HTMLElement).matches(maskTextSelector)) {
@@ -379,7 +385,7 @@ function serializeNode(
maskInputOptions: MaskInputOptions; maskInputOptions: MaskInputOptions;
maskTextFn: MaskTextFn | undefined; maskTextFn: MaskTextFn | undefined;
maskInputFn: MaskInputFn | undefined; maskInputFn: MaskInputFn | undefined;
dataURLOptions?: DataURLOptions, dataURLOptions?: DataURLOptions;
inlineImages: boolean; inlineImages: boolean;
recordCanvas: boolean; recordCanvas: boolean;
keepIframeSrcFn: KeepIframeSrcFn; keepIframeSrcFn: KeepIframeSrcFn;
@@ -516,17 +522,26 @@ function serializeNode(
if ((n as ICanvas).__context === '2d') { if ((n as ICanvas).__context === '2d') {
// only record this on 2d canvas // only record this on 2d canvas
if (!is2DCanvasBlank(n as HTMLCanvasElement)) { if (!is2DCanvasBlank(n as HTMLCanvasElement)) {
attributes.rr_dataURL = (n as HTMLCanvasElement).toDataURL(dataURLOptions.type, dataURLOptions.quality); attributes.rr_dataURL = (n as HTMLCanvasElement).toDataURL(
dataURLOptions.type,
dataURLOptions.quality,
);
} }
} else if (!('__context' in n)) { } else if (!('__context' in n)) {
// context is unknown, better not call getContext to trigger it // context is unknown, better not call getContext to trigger it
const canvasDataURL = (n as HTMLCanvasElement).toDataURL(dataURLOptions.type, dataURLOptions.quality); const canvasDataURL = (n as HTMLCanvasElement).toDataURL(
dataURLOptions.type,
dataURLOptions.quality,
);
// create blank canvas of same dimensions // create blank canvas of same dimensions
const blankCanvas = document.createElement('canvas'); const blankCanvas = document.createElement('canvas');
blankCanvas.width = (n as HTMLCanvasElement).width; blankCanvas.width = (n as HTMLCanvasElement).width;
blankCanvas.height = (n as HTMLCanvasElement).height; blankCanvas.height = (n as HTMLCanvasElement).height;
const blankCanvasDataURL = blankCanvas.toDataURL(dataURLOptions.type, dataURLOptions.quality); const blankCanvasDataURL = blankCanvas.toDataURL(
dataURLOptions.type,
dataURLOptions.quality,
);
// no need to save dataURL if it's the same as blank canvas // no need to save dataURL if it's the same as blank canvas
if (canvasDataURL !== blankCanvasDataURL) { if (canvasDataURL !== blankCanvasDataURL) {
@@ -548,7 +563,10 @@ function serializeNode(
canvasService!.width = image.naturalWidth; canvasService!.width = image.naturalWidth;
canvasService!.height = image.naturalHeight; canvasService!.height = image.naturalHeight;
canvasCtx!.drawImage(image, 0, 0); canvasCtx!.drawImage(image, 0, 0);
attributes.rr_dataURL = canvasService!.toDataURL(dataURLOptions.type, dataURLOptions.quality); attributes.rr_dataURL = canvasService!.toDataURL(
dataURLOptions.type,
dataURLOptions.quality,
);
} catch (err) { } catch (err) {
console.warn( console.warn(
`Cannot inline img src=${image.currentSrc}! Error: ${err}`, `Cannot inline img src=${image.currentSrc}! Error: ${err}`,
@@ -974,7 +992,7 @@ function snapshot(
maskTextFn?: MaskTextFn; maskTextFn?: MaskTextFn;
maskInputFn?: MaskTextFn; maskInputFn?: MaskTextFn;
slimDOM?: boolean | SlimDOMOptions; slimDOM?: boolean | SlimDOMOptions;
dataURLOptions?: DataURLOptions, dataURLOptions?: DataURLOptions;
inlineImages?: boolean; inlineImages?: boolean;
recordCanvas?: boolean; recordCanvas?: boolean;
preserveWhiteSpace?: boolean; preserveWhiteSpace?: boolean;