xuguopeng/rrweb
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix that blob urls persist on the shared anchor element and can't be later modified (#1467)

Browse Source 
* Fix that blob urls persist on the shared anchor element and can't be later modified

* Create nervous-kiwis-nail.md
This commit is contained in:
Eoghan Murray
2024-05-03 12:20:20 +01:00
committed by GitHub
parent 5e7943dbae
commit e96f668c86
2 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
.changeset/nervous-kiwis-nail.md Normal file
View File

@@ -0,0 +1,6 @@
---
'rrweb-snapshot': patch
'rrweb': patch
---
Bugfix after #1434 perf improvements: fix that blob urls persist on the shared anchor element and can't be later modified

2
packages/rrweb-snapshot/src/snapshot.ts
View File

@@ -218,6 +218,8 @@ function getHref(doc: Document, customHref?: string) {
} }
if (!customHref) { if (!customHref) {
customHref = ''; customHref = '';
} else if (customHref.startsWith('blob:') || customHref.startsWith('data:')) {
return customHref;
} }
// note: using `new URL` is slower. See #1434 or https://jsbench.me/uqlud17rxo/1 // note: using `new URL` is slower. See #1434 or https://jsbench.me/uqlud17rxo/1
a.setAttribute('href', customHref); a.setAttribute('href', customHref);