xuguopeng/rrweb
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix: scrolling on elements being is ignored (#1029)

Browse Source 
In certain cases when scrollLeft is being set, but the value doesn't change. Then scrollTop is also ignored, even if that value was changed.
In this case we use the `scrollTo` api as it doesn't have that issue.
This commit is contained in:
Justin Halsall
2022-11-12 09:03:30 +01:00
committed by GitHub
parent 9bbc3e0073
commit fdb7135fbe
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
packages/rrweb/src/replay/index.ts
View File

@@ -1757,8 +1757,11 @@ export class Replayer {
}); });
} else { } else {
try { try {
(target as Element).scrollTop = d.y; (target as Element).scrollTo({
(target as Element).scrollLeft = d.x; top: d.y,
left: d.x,
behavior: isSync ? 'auto' : 'smooth',
});
} catch (error) { } catch (error) {
/** /**
* Seldomly we may found scroll target was removed before * Seldomly we may found scroll target was removed before