Commit Graph

196 Commits

Author SHA1 Message Date
Eoghan Murray
c550cfa614 Reduce verbosity/redundancy of new pointerType attribute (#1206)
* Reduce verbosity/redundancy of output of new pointerType attribute by confining it only to clicks (and to a MouseDown/MouseUp from a PointerTypes.Pen, as these don't yet have a dedicated PendDown/PenUp)

* Update how the changeset will read for the next release based on the trimming in this PR

* Prefer triple equals

* The assignment to the outer `pointerType` variable in an anonymous function was somehow missed by the `typings` check

* Apply formatting changes

* Update packages/rrweb/src/record/observer.ts

* Update packages/rrweb/src/record/observer.ts

---------

Co-authored-by: Yun Feng <yun.feng0817@gmail.com>
2023-04-16 14:28:47 +08:00
Ben White
bc84246f78 feat: Added support maskInputFn with HTMLElement (#1188) 2023-04-15 09:31:39 +02:00
Eoghan Murray
f88471184c Merge pull request #1201 from eoghanmurray/pointerTypeFixups
Pointer type fixups
2023-04-13 11:25:40 +01:00
Eoghan Murray
004d29ba70 eslint was giving an error here 2023-04-12 15:11:51 +01:00
Eoghan Murray
961abec782 Get puppeteer to produce a touch event - this also uncovered an error where a subsequent click would be picked up as a touch (see thisEventKey change) 2023-04-12 15:11:51 +01:00
Eoghan Murray
3ce6903122 Add a baseline test for clicking links 2023-04-12 13:55:05 +01:00
Eoghan Murray
777ab9a7cd pointerType shows up in clicks in these tests on my machine; 0=PointerTypes.Mouse is expected 2023-04-12 13:14:04 +01:00
Eoghan Murray
0228137f51 The type system was complaining about the remote possibility that e ended up as a TouchEvent instead of an individual Touch object I think 2023-04-12 13:13:53 +01:00
Eoghan Murray
b00798099a Fixup type errors 2023-04-12 12:10:04 +01:00
Eoghan Murray
41cc822f1d Merge pull request #1129 from eoghanmurray/pointerType
Record pointerType on clicks
2023-04-12 11:20:10 +01:00
Francesco Novy
aa79db7568 fix: Fix input.type check (#1184)
* fix: Fix input.type check

Actually I noticed that `el.type` returns `text` when type is not explicitly set, so this is slightly incorrect.

* fix linting

* Apply formatting changes
2023-04-08 00:18:22 +10:00
eoghanmurray
be856443dd Apply formatting changes 2023-04-05 15:51:24 +00:00
Eoghan Murray
3a6de4b129 Make the pointerType into an Enum to be consistent with other values in events 2023-04-05 16:49:44 +01:00
eoghanmurray
73ee29f208 Apply formatting changes 2023-03-30 16:12:33 +00:00
Eoghan Murray
351c5551da Record pointerType on clicks - could be useful for displaying e.g. a circle rather than a point during replay
- We have to switch to 'onpointerdown' & 'onpointerup' in order to actually capture `e.pointerType`
 - this replaces 4 event listeners (MouseDown/MouseUp/TouchStart/TouchEnd) with 2 pointer ones which should fire in all 4 scenarios. We still output the old types according to the MouseInteractions enum
 - there is no Pointer equivalent of Click, so we leave that is, but use the last Pointer event to attach a pointerType to (only) the click event, where it is most useful
 - we can fallback to the old method for any browsers not supporting `window.PointerEvent`, in which case \`pointerType\` will be absent from all events
2023-03-30 17:06:52 +01:00
github-actions[bot]
1b2855bde1 Version Packages (alpha) (#1175)
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2023-03-28 19:05:18 +02:00
Yun Feng
f1f5865dcf move rrvideo to monorepo (#1181)
* first commit

* rrvideo v0.1.0

First version of rrvideo.

1. Use as a Node.JS lib.
2. Use as a CLI.

Features are implemented via puppeteer, ffmpeg and rrweb-player.

* add readme

* update publish script

* add node env in cli file and change package.json bin to same like README (#4)

Co-authored-by: Xu Yinjie <xuyinjie@xiaobangtouzi.com>

* release 0.2.0

* fix #6 avoid assign undefined to config

* Fix: Solve the inconsistency between rrvideo and the real recorded page rendering when rendering the page with a headless browser (https://github.com/rrweb-io/rrvideo/pull/26)

Author: xujiujiu <906784584@qq.com>

---------

Co-authored-by: xujiujiu <906784584@qq.com>

* refactor rrvideo

1. refactor code
2. change monorepo config
3. remove separate TS dependencies

* add changeset

* fix: eslint errors

---------

Co-authored-by: Yanzhen Yu <yanzhen@smartx.com>
Co-authored-by: xyj <593500664@qq.com>
Co-authored-by: Xu Yinjie <xuyinjie@xiaobangtouzi.com>
Co-authored-by: xujiujiu <906784584@qq.com>
2023-03-28 19:02:22 +02:00
Justin Halsall
1e6f71b3cd Fix: Trigger mouse movement & hover with mouse up/down in sync mode (#1191)
* Trigger mouse movement & hover with mouse up/down in sync mode

* Trigger touchActive and mouseDown on flush
2023-03-28 18:59:40 +02:00
Yun Feng
267e990dc0 Fix: processed-node-manager is created even in the environment that doesn't need a recorder (#1186)
* Fix: processed-node-manager is created even in the environment that doesn't need a recorder

* apply Justin's suggestion

End the RAF loop when the recorder stops
2023-03-24 17:55:22 +11:00
Francesco Novy
a225d8e141 feat: Allow to pass errorHandler as record option (#1107)
* feat: Allow to pass `errorHandler` as record option

* add docs

* Apply formatting changes
2023-03-22 10:24:36 +08:00
Francesco Novy
d2582e9a81 feat: Ensure password inputs are masked when switching type (#1170)
* feat: Ensure password inputs are masked when switching type


Apply formatting changes

use data- attribute


ref: Ensure type is always lowercased


add changeset

* extract into util

* Apply formatting changes
2023-03-20 20:13:23 +08:00
Eoghan Murray
a82a3b42b1 Extend the suppression of warnings to take into account anscestors (#1145)
* Extend the suppression of warnings to take account that a prior removal may not have been against the immediate parent of a subsequent removal, but rather some anscestor

* Create proud-experts-jam.md

* Apply formatting changes
2023-03-18 17:51:52 +11:00
fukang wang
e0f862bac7 fix: worker_thread warning (#1179)
* fix: worker_thread warning

* Create fast-chefs-smell.md

* Apply formatting changes

* Update fast-chefs-smell.md
2023-03-18 17:21:49 +11:00
fukang wang
5982c8972a fix: Cannot set property attributeName of #<MutationRecord> which has only a getter (#1173)
* fix: Cannot set property attributeName of #<MutationRecord> which has only a getter

* fix: attributeName readonly
2023-03-15 18:11:02 +08:00
sky
4cb4d0e95a improve: some websites rebuild imcomplete (#1163)
* improve: mutation.ts, loop use Set replace Array

* improve: add a try-catch to utils.ts to make it robust

* Create yellow-mails-cheat.md

---------

Co-authored-by: Yun Feng <yun.feng0817@gmail.com>
2023-03-13 14:29:48 +08:00
github-actions[bot]
1f8e5d5675 Version Packages (alpha) (#1138) 2023-03-08 16:06:25 +08:00
Justin Halsall
d292167997 Add tsdoc/jsdoc deprecated notice to Mirror (#1168) 2023-03-08 08:19:37 +01:00
Yun Feng
f27e545e18 Fix: Switch to real dom before rebuilding fullsnapshot (#1139) 2023-03-08 08:19:00 +01:00
Francesco Novy
eac9b18bbf feat: Ignore autoplay attribute on video/audio elements (#1152)
* feat: Ignore `autoplay` attribute on video/auto elements

This element leads to weird issues when replaying, so it's better to strip this out.

* add changeset

* fix check


fix typo

* Apply formatting changes

---------

Co-authored-by: mydea <mydea@users.noreply.github.com>
2023-03-03 13:01:02 +01:00
Eoghan Murray
5e6c132a4d Set userTriggered to false on Input attribute modifications (#1159)
* Set userTriggered to false on Input attribute modifications

 - the fact we are intercepting them via hook rather than an event suggests to me that they could well be programmatic

* Create young-timers-grow.md
2023-03-03 11:35:50 +01:00
Francesco Novy
8e47ca1021 fix: Explicitly handle null attribute values (#1157)
* fix: Explicitly handle removed attributes

The attribute `value` can be null when a mutation observer triggers due to a removed attribute. This is currently not reflected by types and code.

* Apply formatting changes

* fix

* add changeset
2023-02-28 03:32:56 +08:00
Pravin Tiwari
e65465e808 fix the statement which is getting changed by Microbundle (#1156)
* fix the statement which is getting changed by microbundle

* Create chatty-cherries-train.md

* fix formatting.

* fix position of comment

---------

Co-authored-by: Justin Halsall <Juice10@users.noreply.github.com>
2023-02-27 08:58:15 +01:00
Yun Feng
3416c3a769 fix: isCheckout is not included in fullsnapshot event (#1141)
* fix: isCheckout is not included in fullsnapshot event

* add change log
2023-02-17 08:50:58 +01:00
Ben White
aaabdbdff5 fix: Recursive logging bug with console recording (#1136)
* fix: Recursive logging bug with console recording

* Create violet-melons-itch.md
2023-02-16 17:11:31 +08:00
github-actions[bot]
06031a6486 Version Packages (alpha) (#1135) 2023-02-15 06:37:19 +08:00
Yun Feng
033d2d18b4 some minor changes for releasing the extension and revert failed publish PR #1123 (#1132)
* improve extension bundle

* Revert "Version Packages (alpha) (#1123)"

This reverts commit 39f8c24f1d.
2023-02-15 06:32:43 +08:00
github-actions[bot]
39f8c24f1d Version Packages (alpha) (#1123)
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2023-02-14 15:51:42 +01:00
Yun Feng
3cc4323094 improve rrdom performance (#1127)
* add more check to rrdom to make diff algorithm more robust

* fix: selector match in iframe is case-insensitive

add try catch to some fragile points

* test: increase timeout value for Jest

* improve code style

* fix: failed to execute insertBefore on Node in the diff function

this happens when ids of doctype or html element are changed in the virtual dom

also improve the code quality

* refactor diff function to make the code cleaner

* fix: virtual nodes are passed to plugin's onBuild function

* refactor the diff function and adjust the order of diff work.

* call afterAppend hook in a consistent traversal order

* improve the performance of the "contains" function

reduce the complexity from O(n) to O(logn)
a specific benchmark is needed to add further

* add a real events for benchmark

* refactor: change the data structure of childNodes from array to linked list

* remove legacy code in rrweb package

* update unit tests

* update change log
2023-02-14 11:54:30 +01:00
Yun Feng
1385f7acc0 fix duplicated shadow dom (#1095)
* fix: duplicated elements in shadow doms

clean observers before taking new full snapshots

* add checker for replayer to make it stable when data has duplicated nodes

* apply review suggestions

* add change log

* Apply formatting changes

* update prettier to fit the master branch

---------

Co-authored-by: Mark-Fenng <Mark-Fenng@users.noreply.github.com>
2023-02-12 14:00:18 +01:00
Yun Feng
502d15df9f fix: outdated ':hover' styles can't be removed from iframes or shadow doms (#1121)
* fix :hover class can't be removed in iframes

* add test case and change log
2023-02-12 13:25:21 +01:00
Justin Halsall
5a1e5e919e Automate NPM package releases (#1119) 2023-02-11 10:19:52 +01:00
Yun Feng
174b9ac066 fix: mutation Failed to execute 'insertBefore' on 'Node': Only one doctype on document allowed (#1112)
Co-authored-by: Justin Halsall <Juice10@users.noreply.github.com>
2023-02-09 20:21:45 +08:00
Yun Feng
0627d4df7c add option to record on DOMContentLoaded event (#1109) 2023-02-09 10:14:49 +01:00
Yun Feng
07d22e7cd9 enable to customize logger in the replayer (#1111) 2023-02-09 10:14:33 +01:00
Yun Feng
4ee86fe66d improve rrdom robustness (#1091) 2023-02-09 10:10:32 +01:00
Yun Feng
3a26e36f6f fix: regression of issue: ShadowHost can't be a string (issue 941) (#1092) 2023-02-09 10:09:58 +01:00
Eoghan Murray
3caa25ed9b Don't have requestAnimationFrame looping in background for Live Mode (#1098) 2023-02-09 10:02:38 +01:00
Yun Feng
07326182f9 fix: wrong rootId value in special iframes (#1100)
1. When some same-origin iframes are nested in cross-origin iframes, their `rootId`s are wrong.

2. The property `rootId` is missing in serialized cross-origin iframes
2023-02-09 16:23:19 +08:00
Francesco Novy
cb1580008d fix: Ensure CSS support is checked more robustly (#1106)
* fix: Ensure CSS support is checked more robustly

* Apply formatting changes

* apply eslint changes

* Update packages/rrweb/src/record/observer.ts

Co-authored-by: Justin Halsall <Juice10@users.noreply.github.com>

* fix: do not use window in module scope

---------

Co-authored-by: mydea <mydea@users.noreply.github.com>
Co-authored-by: Justin Halsall <Juice10@users.noreply.github.com>
2023-02-09 09:19:53 +01:00
Justin Halsall
25a4f5ab6c [fix] Don't trigger Finish event when in liveMode (#1115) 2023-02-09 08:48:57 +01:00