xuguopeng/rrweb
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: errors of replaying iframe records (#520)

Browse Source 
* fix: errors of replaying iframe records

error1:
HierarchyRequestError: Failed to execute 'appendChild' on 'Node': Nodes of type '#document' may not be inserted inside nodes of type '#document-fragment'.
code: parent.appendChild(target)

error2:
Uncaught DOMException: Failed to execute 'appendChild' on 'Node': Only one element on document allowed.
code: parent.appendChild(target);

* improve the comment for bugfix
This commit is contained in:
Lucky Feng
2026-04-01 12:00:00 +08:00
committed by GitHub
parent fcbc0e4b43
commit 016a5020fc
1 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/replay/index.ts
View File

@@ -1118,7 +1118,8 @@ export class Replayer {
parentInDocument = this.iframe.contentDocument.body.contains(parent);
}
if (useVirtualParent && parentInDocument) {
// if parent element is an iframe, iframe document can't be appended to virtual parent
if (useVirtualParent && parentInDocument && !isIframeINode(parent)) {
const virtualParent = (document.createDocumentFragment() as unknown) as INode;
mirror.map[mutation.parentId] = virtualParent;
this.fragmentParentMap.set(virtualParent, parent);
@@ -1180,6 +1181,15 @@ export class Replayer {
? parent.insertBefore(target, next)
: parent.insertBefore(target, null);
} else {
/**
* Sometimes the document changes and the MutationObserver is disconnected, so the removal of child elements can't be detected and recorded. After the change of document, we may get another mutation which adds a new html element, while the old html element still exists in the dom, and we need to remove the old html element first to avoid collision.
*/
if (parent === targetDoc) {
while (targetDoc.firstChild) {
targetDoc.removeChild(targetDoc.firstChild);
}
}
parent.appendChild(target);
}