xuguopeng/rrweb
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't remove the style attributes altogether from tests; they are an important part of the mutations (#468)

Browse Source 
These were removed in 8ed1c999cf in order to smooth over differences in test environments
so have maintained that by converting pixel values to 'Npx' (could also try rounding, but didn't attempt that)
This commit is contained in:
Eoghan Murray
2026-04-01 12:00:00 +08:00
committed by GitHub
parent 9f3f4d15f2
commit 168382f5fe
2 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
test/__snapshots__/integration.test.ts.snap
View File

@@ -5573,6 +5573,7 @@ exports[`select2 1`] = `
\\"id\\": 36,
\\"attributes\\": {
\\"id\\": \\"select2-drop\\",
\\"style\\": \\"left: Npx; width: Npx; top: Npx; bottom: auto; display: block;\\",
\\"class\\": \\"select2-drop select2-display-none select2-with-searchbox select2-drop-active\\"
}
},
@@ -5721,7 +5722,8 @@ exports[`select2 1`] = `
\\"tagName\\": \\"div\\",
\\"attributes\\": {
\\"class\\": \\"select2-drop select2-display-none select2-with-searchbox select2-drop-active\\",
\\"id\\": \\"select2-drop\\"
\\"id\\": \\"select2-drop\\",
\\"style\\": \\"left: Npx; width: Npx; top: Npx; bottom: auto; display: block;\\"
},
\\"childNodes\\": [],
\\"id\\": 36
@@ -6033,7 +6035,8 @@ exports[`select2 1`] = `
{
\\"id\\": 36,
\\"attributes\\": {
\\"id\\": null
\\"id\\": null,
\\"style\\": \\"left: Npx; width: Npx; top: Npx; bottom: auto; display: none;\\"
}
},
{

6
test/utils.ts
View File

@@ -61,7 +61,7 @@ function stringifySnapshots(snapshots: eventWithTime[]): string {
s.data.href = 'about:blank';
}
// FIXME: travis coordinates seems different with my laptop
const coordinatesReg = /(bottom|top|left|right)/;
const coordinatesReg = /(bottom|top|left|right|width|height): \d+(\.\d+)?px/g
if (
s.type === EventType.IncrementalSnapshot &&
s.data.source === IncrementalSource.MouseInteraction
@@ -78,7 +78,7 @@ function stringifySnapshots(snapshots: eventWithTime[]): string {
'style' in a.attributes &&
coordinatesReg.test(a.attributes.style!)
) {
delete a.attributes.style;
a.attributes.style = a.attributes.style!.replace(coordinatesReg, '$1: Npx');
}
});
s.data.adds.forEach((add) => {
@@ -88,7 +88,7 @@ function stringifySnapshots(snapshots: eventWithTime[]): string {
typeof add.node.attributes.style === 'string' &&
coordinatesReg.test(add.node.attributes.style)
) {
delete add.node.attributes.style;
add.node.attributes.style = add.node.attributes.style.replace(coordinatesReg, '$1: Npx');
}
});
}