check whether the removed node's ancestors has been removed
This commit is contained in:
@@ -7,6 +7,7 @@ import {
|
||||
getWindowHeight,
|
||||
getWindowWidth,
|
||||
isBlocked,
|
||||
isAncestorRemoved,
|
||||
} from '../utils';
|
||||
import {
|
||||
mutationCallBack,
|
||||
@@ -118,7 +119,7 @@ function initMutationObserver(cb: mutationCallBack): MutationObserver {
|
||||
* before callback fired, so we can ignore it.
|
||||
* TODO: verify this
|
||||
*/
|
||||
} else if (!mirror.has(parentId)) {
|
||||
} else if (isAncestorRemoved(target as INode)) {
|
||||
/**
|
||||
* If parent id was not in the mirror map any more, it
|
||||
* means the parent node has already been removed. So
|
||||
|
||||
@@ -625,7 +625,7 @@ export class Replayer {
|
||||
|
||||
private debugNodeNotFound(d: incrementalData, id: number) {
|
||||
/**
|
||||
* There may me some valid scenes of node not being found.
|
||||
* There maybe some valid scenes of node not being found.
|
||||
* Because DOM events are macrotask and MutationObserver callback
|
||||
* is microtask, so events fired on a removed DOM may emit
|
||||
* snapshots in the reverse order.
|
||||
|
||||
18
src/utils.ts
18
src/utils.ts
@@ -126,3 +126,21 @@ export function isBlocked(node: Node | null): boolean {
|
||||
}
|
||||
return isBlocked(node.parentNode);
|
||||
}
|
||||
|
||||
export function isAncestorRemoved(target: INode): boolean {
|
||||
const id = mirror.getId(target);
|
||||
if (!mirror.has(id)) {
|
||||
return true;
|
||||
}
|
||||
if (
|
||||
target.parentNode &&
|
||||
target.parentNode.nodeType === target.DOCUMENT_NODE
|
||||
) {
|
||||
return false;
|
||||
}
|
||||
// if the root is not document, it means the node is not in the DOM tree anymore
|
||||
if (!target.parentNode) {
|
||||
return true;
|
||||
}
|
||||
return isAncestorRemoved((target.parentNode as unknown) as INode);
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user